This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Implement Collator #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
reviewed
Jun 26, 2019
| inherent_data, | ||
| Default::default(), | ||
| //TODO: Fix this. | ||
| Duration::from_secs(6), |
There was a problem hiding this comment.
I'm not sure what to do here, but it is worth noting that polkadot-collator times out collation futures that take longer than a given duration. Maybe we can pass that timeout along to ProduceCandidate somehow.
rphmeier
reviewed
Jun 26, 2019
test/client/src/lib.rs
Outdated
| native_executor_instance!( | ||
| pub LocalExecutor, | ||
| runtime::api::dispatch, | ||
| runtime::native_version, | ||
| include_bytes!("../../runtime/wasm/target/wasm32-unknown-unknown/release/cumulus_test_runtime.compact.wasm") | ||
| runtime::WASM_BINARY |
There was a problem hiding this comment.
Suggested change
| runtime::WASM_BINARY | |
| runtime::WASM_BINARY, |
imstar15
pushed a commit
to imstar15/cumulus
that referenced
this pull request
Nov 16, 2022
…9.26 Mangata dev v0.9.26
Maharacha
pushed a commit
to Maharacha/cumulus
that referenced
this pull request
May 10, 2023
yrong
pushed a commit
to yrong/cumulus
that referenced
this pull request
May 13, 2023
* Add support for new pallets * Update RPC handler for OutboundQueue
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Just concentrate on the collator crate)
Open questions:
max_durationofpropose?produce_candidate?