This repository has been archived by the owner on Feb 28, 2023. It is now read-only.
Prepare for running the dist suite as an unprivileged user #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we used CACHEPOT_LOG env var for the client/coordinator but RUST_LOG for the scheduler/build worker. This uses CACHEPOT_LOG consistently and we also include the information what kind of cachepot service (client/coordinator/scheduler/worker) we are logging from.
No need to spawn the default amount of ~CPU cores for the thread pool, as the only use is to wait for a UDS connection with a simple timeout.
drahnr
reviewed
Feb 5, 2022
drahnr
reviewed
Feb 5, 2022
| @@ -1,6 +1,6 @@ | |||
| public_addr = "http://127.0.0.1:10600" | |||
|
|
|||
| [server_auth] | |||
| [worker_auth] | |||
drahnr
approved these changes
Feb 5, 2022
|
Er, did I fat-finger something? I enabled the auto-merge but I don't remember merging this by hand and the other checks are still running... In any case, that was not intentional! But the CI was green before so there's that 😅 |
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uncontroversial bits of #128
Let's land this first to minimize bitrot and let #128 focus strictly on sandboxing details (need to update it to use fuse-overlayfs and separate another binary entrypoint for the unshared userns variant of the sandbox)