-
Notifications
You must be signed in to change notification settings - Fork 13
Conversation
I'll give this a spin at some point this week, other than that this is looks good to me and ready to be merged 🎉 |
yields
with the local dispatch ( or local server) logs:
|
Were all previously launched instances of daemonized |
Double checked: After running Imho this error message is a bug in itself, it provides insufficient context: |
Damn, I cant repro and i didn't even touch |
Can you |
Also, I've run into |
I think my local redis just crashed and this is a side effect of it. I'll try to fix the instance, and open an issue regarding error handling of the backend if this is resolved. |
I can't repro, I'm getting regular stat dump using this branch |
After fixing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excited for this change! 🎉 Looks good at a glance, I'll dig deeper later on since I had a hard time following the logic bundled together in a single file
} | ||
} | ||
|
||
mod scheduler_api_v1 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it'd makes to extract API routes/logic to separate files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest in another changeset.
|
||
impl warp::reject::Reject for Error {} | ||
|
||
pub(super) mod filters { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto wrt modules
} | ||
} | ||
|
||
pub(super) mod handlers { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
Merged this since it is blocking all stuff that needs to be done on top of it. In case there (most likely) be fallout lets deal with it iteratively in new issues. |
Still a lot of work to do but I think that api will be compatible with old code.
Fixes #39