Avoid non-identifier export names in non-entry library bundles #9587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup from #9489 (comment). It turns out that webpack 4 doesn't support parsing string export syntax, and it is still pretty widely used, so we should try to avoid this. This PR strikes a balance: it will still export non-identifier symbols if the CJS module was an entry (since the author probably has control over this) but it will avoid it for internal bundles where we already only use the
defaultexport to import the namespace anyway. This passes our existing test and fixes the cases we need for React Spectrum.