Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the relative distDir when generating the bundle id #4940

Merged
merged 5 commits into from
Aug 17, 2020
Merged

Use the relative distDir when generating the bundle id #4940

merged 5 commits into from
Aug 17, 2020

Conversation

mischnic
Copy link
Member

@mischnic mischnic commented Jul 27, 2020 •
edited
Loading

↪️ Pull Request

Closes #4894

The bundle id was generated using the absolute dist dir path, not relative to the project root

Regression from #4231:

To fix this, we now include the target's dist directory in the id of the bundle so that two targets in different output directories never share bundles.

Maybe this should not actually use distdir at all and try to make the bundle id unique between targets in some other way.

@height
Copy link

height bot commented Jul 27, 2020

Link Height tasks by mentioning a task ID in the pull request title or description, commit messages, or comments.

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@parcel-benchmark
Copy link

parcel-benchmark commented Jul 27, 2020 •
edited
Loading

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 5.71s -237.00ms
Cached 2.12s +20.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.d5807e82.webp 102.94kb +0.00b 142.00ms -124.00ms 🚀
dist/modern/parcel.d5807e82.webp 102.94kb +0.00b 142.00ms -124.00ms 🚀
dist/legacy/index.42516b4a.js 1.10kb +0.00b 1.34s -242.00ms 🚀
dist/modern/index.8a1ced31.js 1.10kb +0.00b 475.00ms -1.11s 🚀
dist/legacy/index.html 701.00b +0.00b 603.00ms -39.00ms 🚀
dist/modern/index.html 701.00b +0.00b 601.00ms -38.00ms 🚀
dist/modern/index.e480862d.css 77.00b +0.00b 1.34s -128.00ms 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.d5807e82.webp 102.94kb +0.00b 224.00ms +67.00ms ⚠️
dist/modern/parcel.d5807e82.webp 102.94kb +0.00b 223.00ms +66.00ms ⚠️
dist/legacy/index.42516b4a.js 1.10kb +0.00b 452.00ms +75.00ms ⚠️
dist/modern/index.8a1ced31.js 1.10kb +0.00b 451.00ms +73.00ms ⚠️
dist/legacy/index.html 701.00b +0.00b 458.00ms +80.00ms ⚠️
dist/modern/index.html 701.00b +0.00b 451.00ms +74.00ms ⚠️
dist/legacy/index.0e158b6b.css 77.00b +0.00b 452.00ms +75.00ms ⚠️
dist/modern/index.e480862d.css 77.00b +0.00b 451.00ms +74.00ms ⚠️

React HackerNews ✅

Timings

Description Time Difference
Cold 26.26s -259.00ms
Cached 2.17s -139.00ms 🚀

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/index.js 479.25kb +0.00b 246.00ms -29.00ms 🚀
dist/PermalinkedComment.c85d137d.js 4.22kb +0.00b 244.00ms -29.00ms 🚀
dist/UserProfile.30e15baf.js 1.62kb +0.00b 244.00ms -29.00ms 🚀
dist/NotFound.5aa6b041.js 387.00b +0.00b 244.00ms -29.00ms 🚀

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 2.61m -7.44s
Cached 4.95s +24.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/index.a86f4f60.js 2.73mb -4.00b 🚀 1.48m -3.74s
dist/pdfRenderer.cd742f5e.js 1.11mb -6.00b 🚀 46.91s -1.35s
dist/popup.4a66e15e.js 170.62kb +0.00b 48.34s +18.46s ⚠️
dist/Toolbar.33a83ae3.js 92.34kb +0.00b 52.28s -40.16s 🚀
dist/EmojiPickerComponent.834d796f.js 75.29kb +0.00b 9.10s -726.00ms 🚀
dist/media-viewer.a8f3a476.js 72.02kb +0.00b 13.15s -994.00ms 🚀
dist/card.1758a622.js 55.09kb +0.00b 10.62s -1.51s 🚀
dist/Modal.e3bd77d0.js 41.40kb +0.00b 5.40s -608.00ms 🚀
dist/component.59edff1f.js 30.78kb +0.00b 2.17s -177.00ms 🚀
dist/component.37867f50.js 22.51kb +0.00b 5.33s -672.00ms 🚀
dist/DatePicker.bb2cab18.js 21.17kb +0.00b 9.10s -726.00ms 🚀
dist/EmojiPickerComponent.898d8be6.js 18.23kb +0.00b 9.10s -1.37m 🚀
dist/js.48be70a4.js 16.40kb +0.00b 5.33s -591.00ms 🚀
dist/ui.cee430a3.js 13.97kb +0.00b 10.62s -1.51s 🚀
dist/workerHasher.65b8a1b7.js 11.78kb +0.00b 51.03s +38.91s ⚠️
dist/EmojiTypeAheadComponent.9af6e5fc.js 8.67kb +0.00b 51.03s +40.78s ⚠️
dist/component.11476a92.js 6.05kb +0.00b 5.12s -2.21s 🚀
dist/card.4ac5c1b2.js 5.61kb +0.00b 10.62s -3.52s 🚀
dist/media-viewer.bc661bce.js 3.92kb +0.00b 12.97s -1.17s 🚀
dist/EmojiPickerComponent.624bf3f4.js 3.58kb +0.00b 9.10s -1.15s 🚀
dist/index.393afe59.css 3.46kb +0.00b 53.13s -39.94s 🚀
dist/png-chunks-extract.8d15a914.js 3.41kb +0.00b 5.33s -591.00ms 🚀
dist/dropzone.2f1a1e17.js 3.23kb +0.00b 25.51s -1.64s 🚀
dist/Modal.2835744c.js 3.08kb +0.00b 5.33s -591.00ms 🚀
dist/16.d1b8e6f7.js 2.38kb +0.00b 2.13s -214.00ms 🚀
dist/EmojiUploadComponent.88a444df.js 2.18kb +0.00b 51.03s +40.78s ⚠️
dist/card.cadccd96.js 2.03kb +0.00b 12.97s -14.15s 🚀
dist/ResourcedEmojiComponent.d9a49606.js 2.00kb +0.00b 5.02s +1.60s ⚠️
dist/date.d49e64f8.js 1.73kb +0.00b 5.81s -1.44s 🚀
dist/16.f40c1329.js 1.73kb +0.00b 5.69s -1.27s 🚀
dist/images.80270b1f.js 1.67kb +0.00b 5.94s -1.31s 🚀
dist/16.86a8c7d4.js 1.66kb +0.00b 6.81s -1.03s 🚀
dist/feedback.8b7c7928.js 1.64kb +0.00b 6.31s -3.52s 🚀
dist/workerHasher.9bb425b1.js 1.54kb +0.00b 51.03s +40.78s ⚠️
dist/list-number.4632b459.js 1.46kb +0.00b 6.02s -1.38s 🚀
dist/status.cccf04be.js 1.46kb +0.00b 6.19s -1.33s 🚀
dist/16.cff410ff.js 1.38kb +0.00b 5.51s -1.30s 🚀
dist/code.af9ca2b3.js 1.38kb +0.00b 5.81s -1.33s 🚀
dist/16.c1ed07f8.js 1.33kb +0.00b 6.81s -513.00ms 🚀
dist/16.6603f2f3.js 1.33kb +0.00b 5.51s -1.18s 🚀
dist/16.a4b392c2.js 1.32kb +0.00b 2.13s -213.00ms 🚀
dist/16.249c644a.js 1.31kb +0.00b 5.81s -1.33s 🚀
dist/link.d12cc130.js 1.30kb +0.00b 6.02s -1.38s 🚀
dist/heading6.4c4017db.js 1.30kb +0.00b 6.31s -3.52s 🚀
dist/heading3.93606b9c.js 1.29kb +0.00b 6.19s -1.39s 🚀
dist/16.ab5c0088.js 1.27kb +0.00b 5.69s -1.45s 🚀
dist/emoji.e603e70e.js 1.23kb +0.00b 5.94s -1.31s 🚀
dist/16.afee1494.js 1.23kb +0.00b 5.69s -1.27s 🚀
dist/16.e60b4d77.js 1.21kb +0.00b 2.13s -213.00ms 🚀
dist/16.7c7a40c9.js 1.19kb +0.00b 5.69s -1.27s 🚀
dist/16.06d5a67b.js 1.18kb +0.00b 5.81s -1.33s 🚀
dist/heading5.dde15cec.js 1.17kb +0.00b 6.31s -1.28s 🚀
dist/expand.6889aead.js 1.16kb +0.00b 6.31s -3.52s 🚀
dist/media-card-analytics-error-boundary.6a25b970.js 1.15kb +0.00b 25.51s -1.61s 🚀
dist/16.2096b9f3.js 1.14kb +0.00b 2.13s -213.00ms 🚀
dist/16.f040d62d.js 1.14kb +0.00b 5.51s -1.44s 🚀
dist/16.1b342686.js 1.13kb +0.00b 5.51s -1.18s 🚀
dist/16.2e7f52c6.js 1.13kb +0.00b 5.51s -1.19s 🚀
dist/16.da43aa07.js 1.13kb +0.00b 6.81s -513.00ms 🚀
dist/heading2.e219309a.js 1.11kb +0.00b 6.19s -1.39s 🚀
dist/16.dd07505e.js 1.10kb +0.00b 5.02s +1.56s ⚠️
dist/component.40194190.js 1.07kb +0.00b 5.02s +1.60s ⚠️
dist/mention.b1828447.js 1.07kb +0.00b 6.02s -1.38s 🚀
dist/heading4.5316f6f2.js 1.06kb +0.00b 6.31s -1.28s 🚀
dist/16.317b9164.js 1.05kb +0.00b 5.69s -1.27s 🚀
dist/layout.ac6734f9.js 1.05kb +0.00b 5.94s -1.46s 🚀
dist/divider.d2be55a1.js 1.03kb +0.00b 5.94s -1.31s 🚀
dist/quote.f4e09143.js 1.02kb +0.00b 6.10s -1.43s 🚀
dist/action.cb287eb0.js 1.00kb +0.00b 5.81s -1.33s 🚀
dist/decision.91f3af14.js 1010.00b +0.00b 5.94s -1.31s 🚀
dist/panel-warning.68b04096.js 1008.00b +0.00b 6.10s -1.43s 🚀
dist/list.057cb664.js 978.00b +0.00b 6.02s -1.38s 🚀
dist/heading1.fa66b375.js 976.00b +0.00b 6.19s -1.40s 🚀
dist/panel-error.c4b05f6f.js 906.00b +0.00b 6.02s -43.67s 🚀
dist/panel.9dbc048e.js 897.00b +0.00b 6.10s -1.43s 🚀
dist/table.b35545be.js 889.00b +0.00b 6.19s -1.33s 🚀
dist/panel-success.7eb0809a.js 845.00b +0.00b 6.10s -43.60s 🚀
dist/panel-note.ec8386b7.js 841.00b +0.00b 6.10s -43.60s 🚀
dist/media-picker-analytics-error-boundary.553055f6.js 837.00b +0.00b 44.45s -4.45s 🚀
dist/media-card-analytics-error-boundary.964206cc.js 833.00b +0.00b 10.62s -1.50s 🚀
dist/media-viewer-analytics-error-boundary.bbe40a02.js 757.00b +0.00b 12.97s -1.19s 🚀
dist/EmojiPickerComponent.a968dafe.js 535.00b +0.00b 9.10s -1.15s 🚀
dist/simpleHasher.f8e69464.js 528.00b +0.00b 10.62s -1.50s 🚀
dist/index.html 119.00b +0.00b 2.30s -2.31s 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/index.a86f4f60.js 2.73mb +3.00b ⚠️ 565.00ms +46.00ms ⚠️
dist/pdfRenderer.cd742f5e.js 1.11mb +0.00b 561.00ms +46.00ms ⚠️
dist/editorView.ae59b49f.js 585.98kb +0.00b 560.00ms +45.00ms ⚠️
dist/popup.4a66e15e.js 170.62kb +0.00b 561.00ms +45.00ms ⚠️
dist/Toolbar.33a83ae3.js 92.34kb +0.00b 560.00ms +45.00ms ⚠️
dist/EmojiPickerComponent.834d796f.js 75.29kb +0.00b 561.00ms +45.00ms ⚠️
dist/media-viewer.a8f3a476.js 72.02kb +0.00b 561.00ms +46.00ms ⚠️
dist/card.1758a622.js 55.09kb +0.00b 561.00ms +46.00ms ⚠️
dist/card.9c09b110.js 52.86kb +0.00b 560.00ms +44.00ms ⚠️
dist/Modal.e3bd77d0.js 41.40kb +0.00b 564.00ms +46.00ms ⚠️
dist/component.59edff1f.js 30.78kb +0.00b 564.00ms +46.00ms ⚠️
dist/component.37867f50.js 22.51kb +0.00b 564.00ms +46.00ms ⚠️
dist/DatePicker.bb2cab18.js 21.17kb +0.00b 561.00ms +45.00ms ⚠️
dist/EmojiPickerComponent.898d8be6.js 18.23kb +0.00b 561.00ms +45.00ms ⚠️
dist/dropzone.812039de.js 17.27kb +0.00b 560.00ms +44.00ms ⚠️
dist/smartMediaEditor.c0ff7bfa.js 16.87kb +0.00b 560.00ms +45.00ms ⚠️
dist/js.48be70a4.js 16.40kb +0.00b 564.00ms +46.00ms ⚠️
dist/ui.cee430a3.js 13.97kb +0.00b 561.00ms +46.00ms ⚠️
dist/workerHasher.65b8a1b7.js 11.78kb +0.00b 561.00ms +46.00ms ⚠️
dist/EmojiTypeAheadComponent.9af6e5fc.js 8.67kb +0.00b 561.00ms +46.00ms ⚠️
dist/component.11476a92.js 6.05kb +0.00b 564.00ms +46.00ms ⚠️
dist/card.4ac5c1b2.js 5.61kb +0.00b 561.00ms +46.00ms ⚠️
dist/media-viewer.bc661bce.js 3.92kb +0.00b 561.00ms +46.00ms ⚠️
dist/EmojiPickerComponent.624bf3f4.js 3.58kb +0.00b 561.00ms +45.00ms ⚠️
dist/index.393afe59.css 3.46kb +0.00b 560.00ms +45.00ms ⚠️
dist/png-chunks-extract.8d15a914.js 3.41kb +0.00b 564.00ms +46.00ms ⚠️
dist/dropzone.2f1a1e17.js 3.23kb +0.00b 561.00ms +45.00ms ⚠️
dist/Modal.2835744c.js 3.08kb +0.00b 564.00ms +46.00ms ⚠️
dist/clipboard.0244488f.js 2.75kb +0.00b 560.00ms +44.00ms ⚠️
dist/16.d1b8e6f7.js 2.38kb +0.00b 564.00ms +46.00ms ⚠️
dist/EmojiUploadComponent.88a444df.js 2.18kb +0.00b 561.00ms +46.00ms ⚠️
dist/card.cadccd96.js 2.03kb +0.00b 561.00ms +45.00ms ⚠️
dist/ResourcedEmojiComponent.d9a49606.js 2.00kb +0.00b 564.00ms +45.00ms ⚠️
dist/date.d49e64f8.js 1.73kb +0.00b 563.00ms +46.00ms ⚠️
dist/16.f40c1329.js 1.73kb +0.00b 564.00ms +46.00ms ⚠️
dist/images.80270b1f.js 1.67kb +0.00b 563.00ms +46.00ms ⚠️
dist/16.86a8c7d4.js 1.66kb +0.00b 565.00ms +47.00ms ⚠️
dist/feedback.8b7c7928.js 1.64kb +0.00b 562.00ms +46.00ms ⚠️
dist/browser.16c438d4.js 1.61kb +0.00b 560.00ms +44.00ms ⚠️
dist/workerHasher.9bb425b1.js 1.54kb +0.00b 561.00ms +46.00ms ⚠️
dist/workerHasher.f66f00c7.js 1.54kb +0.00b 560.00ms +45.00ms ⚠️
dist/list-number.4632b459.js 1.46kb +0.00b 563.00ms +47.00ms ⚠️
dist/status.cccf04be.js 1.46kb +0.00b 562.00ms +46.00ms ⚠️
dist/16.cff410ff.js 1.38kb +0.00b 564.00ms +46.00ms ⚠️
dist/code.af9ca2b3.js 1.38kb +0.00b 563.00ms +46.00ms ⚠️
dist/16.c1ed07f8.js 1.33kb +0.00b 565.00ms +47.00ms ⚠️
dist/16.6603f2f3.js 1.33kb +0.00b 564.00ms +46.00ms ⚠️
dist/16.a4b392c2.js 1.32kb +0.00b 564.00ms +46.00ms ⚠️
dist/16.249c644a.js 1.31kb +0.00b 564.00ms +47.00ms ⚠️
dist/link.d12cc130.js 1.30kb +0.00b 563.00ms +47.00ms ⚠️
dist/heading6.4c4017db.js 1.30kb +0.00b 562.00ms +46.00ms ⚠️
dist/heading3.93606b9c.js 1.29kb +0.00b 562.00ms +46.00ms ⚠️
dist/16.ab5c0088.js 1.27kb +0.00b 564.00ms +46.00ms ⚠️
dist/emoji.e603e70e.js 1.23kb +0.00b 563.00ms +46.00ms ⚠️
dist/16.afee1494.js 1.23kb +0.00b 564.00ms +46.00ms ⚠️
dist/16.e60b4d77.js 1.21kb +0.00b 564.00ms +46.00ms ⚠️
dist/16.7c7a40c9.js 1.19kb +0.00b 564.00ms +46.00ms ⚠️
dist/16.06d5a67b.js 1.18kb +0.00b 564.00ms +47.00ms ⚠️
dist/heading5.dde15cec.js 1.17kb +0.00b 562.00ms +46.00ms ⚠️
dist/expand.6889aead.js 1.16kb +0.00b 561.00ms +45.00ms ⚠️
dist/media-card-analytics-error-boundary.6a25b970.js 1.15kb +0.00b 561.00ms +45.00ms ⚠️
dist/16.2096b9f3.js 1.14kb +0.00b 564.00ms +46.00ms ⚠️
dist/16.f040d62d.js 1.14kb +0.00b 564.00ms +46.00ms ⚠️
dist/16.ecf8a702.js 1.13kb +0.00b 564.00ms +46.00ms ⚠️
dist/16.1b342686.js 1.13kb +0.00b 564.00ms +46.00ms ⚠️
dist/16.2e7f52c6.js 1.13kb +0.00b 564.00ms +46.00ms ⚠️
dist/16.da43aa07.js 1.13kb +0.00b 564.00ms +46.00ms ⚠️
dist/heading2.e219309a.js 1.11kb +0.00b 562.00ms +46.00ms ⚠️
dist/16.dd07505e.js 1.10kb +0.00b 564.00ms +45.00ms ⚠️
dist/component.40194190.js 1.07kb +0.00b 564.00ms +45.00ms ⚠️
dist/mention.b1828447.js 1.07kb +0.00b 563.00ms +47.00ms ⚠️
dist/heading4.5316f6f2.js 1.06kb +0.00b 562.00ms +46.00ms ⚠️
dist/16.317b9164.js 1.05kb +0.00b 564.00ms +46.00ms ⚠️
dist/layout.ac6734f9.js 1.05kb +0.00b 563.00ms +46.00ms ⚠️
dist/divider.d2be55a1.js 1.03kb +0.00b 563.00ms +46.00ms ⚠️
dist/quote.f4e09143.js 1.02kb +0.00b 562.00ms +46.00ms ⚠️
dist/action.cb287eb0.js 1.00kb +0.00b 564.00ms +47.00ms ⚠️
dist/decision.91f3af14.js 1010.00b +0.00b 563.00ms +46.00ms ⚠️
dist/panel-warning.68b04096.js 1008.00b +0.00b 563.00ms +47.00ms ⚠️
dist/list.057cb664.js 978.00b +0.00b 563.00ms +47.00ms ⚠️
dist/heading1.fa66b375.js 976.00b +0.00b 562.00ms +46.00ms ⚠️
dist/panel-error.c4b05f6f.js 906.00b +0.00b 563.00ms +47.00ms ⚠️
dist/panel.9dbc048e.js 897.00b +0.00b 562.00ms +46.00ms ⚠️
dist/table.b35545be.js 889.00b +0.00b 562.00ms +46.00ms ⚠️
dist/panel-success.7eb0809a.js 845.00b +0.00b 563.00ms +47.00ms ⚠️
dist/panel-note.ec8386b7.js 841.00b +0.00b 563.00ms +47.00ms ⚠️
dist/media-picker-analytics-error-boundary.553055f6.js 837.00b +0.00b 561.00ms +45.00ms ⚠️
dist/media-card-analytics-error-boundary.964206cc.js 833.00b +0.00b 561.00ms +46.00ms ⚠️
dist/media-card-analytics-error-boundary.57503222.js 833.00b +0.00b 560.00ms +44.00ms ⚠️
dist/media-viewer-analytics-error-boundary.bbe40a02.js 757.00b +0.00b 561.00ms +46.00ms ⚠️
dist/EmojiPickerComponent.a968dafe.js 535.00b +0.00b 561.00ms +46.00ms ⚠️
dist/simpleHasher.f8e69464.js 528.00b +0.00b 561.00ms +46.00ms ⚠️
dist/simpleHasher.32d9352e.js 528.00b +0.00b 560.00ms +45.00ms ⚠️
dist/index.html 119.00b +0.00b 568.00ms +45.00ms ⚠️

Three.js x4 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

Click here to view a detailed benchmark overview.

@mischnic mischnic merged commit 64ebc37 into v2 Aug 17, 2020
@mischnic mischnic deleted the distdir-hash branch August 17, 2020 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devongovett devongovett devongovett approved these changes

@wbinnssmith wbinnssmith Awaiting requested review from wbinnssmith

@DeMoorJasper DeMoorJasper Awaiting requested review from DeMoorJasper

@padmaia padmaia Awaiting requested review from padmaia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Content hash changes if working directory changes
3 participants
@mischnic @parcel-benchmark @devongovett