Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pnpm migration #4566

Merged
merged 19 commits into from
May 1, 2024
Merged

Pnpm migration #4566

merged 19 commits into from
May 1, 2024

Conversation

manojVivek
Copy link
Contributor

No description provided.

Copy link

alwaysmeticulous bot commented Apr 30, 2024

🤖 Meticulous spotted visual differences in 66 of 352 screens tested: view and approve differences detected.

Last updated for commit 19c0210. This comment will update as new commits are pushed.

Copy link
Member

@brancz brancz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, I was a bit worried the earley parser was going to cause trouble, but looks like it was pretty smooth. Nice work!

Copy link
Contributor

@yomete yomete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

Copy link
Member

@metalmatze metalmatze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing! 🚀

Copy link
Member

@maxbrunet maxbrunet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

just one comment

.github/workflows/build-test.yml Outdated Show resolved Hide resolved
Co-authored-by: Maxime Brunet <[email protected]>
@manojVivek manojVivek merged commit e1be2a7 into main May 1, 2024
38 checks passed
@manojVivek manojVivek deleted the pnpm-migration branch May 1, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants