Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Unify date time format in Metrics graph #4247

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Conversation

yomete
Copy link
Contributor

@yomete yomete commented Jan 3, 2024

Changes in this PR:

  • Ensures the x-axis date-time format uses the American format (month before the day).
  • Make use of the 24H clock across board.
  • When zooming in on the metrics graph, show the hour and seconds in the 24H format, as opposed to just the hour only.

@yomete yomete requested a review from a team as a code owner January 3, 2024 09:42
Copy link

alwaysmeticulous bot commented Jan 3, 2024

🤖 Meticulous spotted visual differences in 315 of 405 screens tested: view and approve differences detected.

Last updated for commit a69614d. This comment will update as new commits are pushed.

Copy link
Contributor

@manojVivek manojVivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@yomete yomete merged commit 0064835 into main Jan 3, 2024
37 of 38 checks passed
@yomete yomete deleted the unify-date-time-format branch January 3, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants