config: Validate duplicate job names #3986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Can you try running the benchmarks? They seem to fail consistently on CI. |
This commit fixes the problem when jobs with the same names are compacted to a single target, leading to an unexpected behavior: a user will only see the last target with this job name. It is a breaking change for users who have duplicates in their configs, but for new users it will be more transparent.
This test is needed to validate that the case from the doc is working (desired parca + parca-agent installation).
nabokihms
force-pushed
the
validate-duplicate-job-names
branch
from
c731278 to
845c442
Compare
|
@brancz sorry, it was my mistake. I accidentally made the scrape config required. |
|
Thank you so much for the contribution! |
|
@all-contributors Please add @nabokihms for code. |
|
I've put up a pull request to add @nabokihms! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the problem when jobs with the same names are compacted to a single target, leading to unexpected behavior: a user will only see the last target with this job name.
It is a breaking change for users who have duplicates in their configs, but for new users, it will be more transparent.