Fix sharing profile bug #3818
Merged
Fix sharing profile bug #3818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Meticulous spotted visual differences in 6 of 318 screens tested: view and approve differences detected. Last updated for commit b986f6f. This comment will update as new commits are pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where clicking on the "Copy Link" button in the profile sharing modal refreshes the page and navigates to the homepage (
/). The use of theformtag seemed to be the issue here.This also fixes a bug I noticed where hovering on any part of the icicle graph causes the app to crash instantly, with the error seen in the screenshot below. Looks like the check
mappingBuildID === nullwasn't enough, changing it to!mappingBuildIDworked.