pkg/query: Use hash of labels instead of marshaling labels to json #3719
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Profiling data showed that:
Were quite expensive (10-15% CPU of flamegraph rendering).
xxhash3 is extremely fast (it's in a way replacing the json being built), and we'll no longer use strings for key/values anywhere, which is much faster to begin with. This does come with the veeeeeery small chance of a hash collision of label-sets. I'd happily see that happen though and then address it.