ui: Docked Graph MetaInfo Panel #3683
Conversation
|
🤖 Meticulous spotted visual differences in 16 of 322 screens tested: view and approve differences detected. Last updated for commit d96b3fa. This comment will update as new commits are pushed. |
@monicawoj You need to enable |
| return `${valueFormatter(hoveringNodeCumulative, unit, 2)} | ||
| (${(100 * divide(hoveringNodeCumulative, totalUnfiltered)).toFixed(2)}%${filtered})`; | ||
| }; | ||
| const {name, locationAddress, cumulativeText, diffText, diff, row: rowNo} = graphTooltipData; |
There was a problem hiding this comment.
Super minor comment, but could we rename "rowNo" to "rowNumber". "No" can be interpreted in multiple ways.
There was a problem hiding this comment.
Done, addressed it.
|
Just FYI, Arrow is the only and default API used for querying flame graphs now. Not sure this changes anything in this PR, but it might make things a littler easier? |
* Extracted the tooltip data logic into hooks for reuse on the new design * Docked graph tooltip * Dock and undock buttons right in the metainfo panel * Lint error fixed * Variable name fixed to be more meaningful * Arrow string conversion --------- Co-authored-by: Monica Wojciechowska <[email protected]>
* add show hide legend button and url state * align columns, show full name on hover * hide legend button on compare mode and default color preferences * change default color profile to ocean * change display names of color palettes * ui: Docked Graph MetaInfo Panel (#3683) * Extracted the tooltip data logic into hooks for reuse on the new design * Docked graph tooltip * Dock and undock buttons right in the metainfo panel * Lint error fixed * Variable name fixed to be more meaningful * Arrow string conversion --------- Co-authored-by: Monica Wojciechowska <[email protected]> * Publish - @parca/[email protected] - @parca/[email protected] - @parca/[email protected] - @parca/[email protected] - @parca/[email protected] - @parca/[email protected] - @parca/[email protected] * remove duplicate object entry * fix ts error and button props --------- Co-authored-by: Manoj Vivek <[email protected]> Co-authored-by: manojVivek <[email protected]>
Screenshots:
