Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: Sources Panel UI improvements #3657

Merged
merged 7 commits into from
Aug 23, 2023
Merged

ui: Sources Panel UI improvements #3657

merged 7 commits into from
Aug 23, 2023

Conversation

manojVivek
Copy link
Contributor

@manojVivek manojVivek commented Aug 21, 2023 •
edited
Loading

Contains:

  • Dark mode color fixes
  • Scrolling to line number
  • Source pane scroll enabled
  • Enabling the open button based on the API response
  • Restructuring to enable GitHub like yellow highlighting for the selected line
  • Some UX tweaks to the cumulative and flat columns
  • Resolve Type errors

@manojVivek manojVivek requested a review from a team as a code owner August 21, 2023 12:43
@manojVivek manojVivek changed the title Dark mode color fixes, Scrolling to line number and source pane scrol… ui: Dark mode color fixes, Scrolling to line number and source pane scroll enabled Aug 21, 2023
@manojVivek manojVivek changed the title ui: Dark mode color fixes, Scrolling to line number and source pane scroll enabled ui: Sources Panel UI improvements Aug 23, 2023
@brancz brancz merged commit e70b641 into read-sources Aug 23, 2023
@brancz brancz deleted the read-source-ui branch August 23, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manojVivek @brancz