Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/storage: Handle errors in iterators early #344

Merged
merged 1 commit into from
Oct 20, 2021
Merged

pkg/storage: Handle errors in iterators early #344

merged 1 commit into from
Oct 20, 2021

Conversation

metalmatze
Copy link
Member

We weren't properly handling errors in the iterators and in some edge cases that caused funny behavior like endless loops.

@metalmatze metalmatze requested a review from brancz October 20, 2021 14:33
brancz
brancz reviewed Oct 20, 2021
View reviewed changes
Copy link
Member

@brancz brancz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be about to embarrass myself on a live stream on twitch but I think we have a bug here with the locking mechanisms?

pkg/storage/series_iterator.go Show resolved Hide resolved
pkg/storage/series_iterator_range.go Show resolved Hide resolved
pkg/storage/series_iterator_root.go Show resolved Hide resolved
brancz
brancz approved these changes Oct 20, 2021
View reviewed changes
Copy link
Member

@brancz brancz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brancz brancz merged commit b3594a0 into main Oct 20, 2021
@brancz brancz deleted the storage-iterator-error-handling branch October 20, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brancz brancz brancz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@metalmatze @brancz