Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/server: Remove cmdline endpoint #3423

Merged
merged 4 commits into from
Sep 7, 2023
Merged

pkg/server: Remove cmdline endpoint #3423

merged 4 commits into from
Sep 7, 2023

Conversation

brancz
Copy link
Member

@brancz brancz commented Jul 8, 2023

This endpoint has the potential to expose secrets if they are passed raw. While we don't recommend this or include it in any examples it's technically possible.

This endpoint has the potential to expose secrets if they are passed raw. While we don't recommend this or include it in any examples it's technically possible.
@brancz brancz requested a review from a team as a code owner July 8, 2023 10:34
brancz added a commit to parca-dev/parca-agent that referenced this pull request Jul 10, 2023
@metalmatze metalmatze enabled auto-merge (squash) July 11, 2023 09:24
auto-merge was automatically disabled August 14, 2023 13:05

Merge queue setting changed

@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Sep 7, 2023

✅ Meticulous spotted zero visual differences across 314 screens tested: view results.

Last updated for commit fd102de. This comment will update as new commits are pushed.

@metalmatze metalmatze merged commit 9d0c578 into main Sep 7, 2023
@brancz brancz deleted the brancz-patch-1 branch September 7, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants