fix(server): handle gRPC-Web requests over HTTP2 #3352
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After much testing, I found out the following:
HTTP1.1 works: ✔️
H2C (HTTP2 upgraded from HTTP1.1) works: ✔️
HTTP2 (without upgrade from HTTP1.1) does not work: ❌
This patch fixes it: ✔️
gRPC-Web requests can use HTTP2, and most modern browsers actually use it if the host supports it.
This latest case happens if the reverse proxy (e.g. Envoy) forwards HTTP2 to HTTP2. Until now, we had been using NGINX in the demo which downgrades the request to HTTP1.1, so the issue had not been surfaced.
This should unblock advanced use cases with mixed client protocols (HTTP1.1/HTTP2/H2C, gRPC/gRPC-Web).