fix click, drag, and keydown behavior #3208
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves MetricsGraph issues regarding point selection, range selection, freezing the tooltip, and taking screenshots.
Problem:
We've had several reports of bugs when interacting with the MetricsGraph. Sometimes, the MetricsGraph goes into a mode where instead of clicking on a point it will zoom in, the MetricsGraph Tooltip doesn't work anymore either.
Solution:
Currently, we have special logic in place that freezes the Metrics Graph tooltip when the user holds down the 'Shift' key. However, 'Shift' is a special key that is used for certain shortcuts (such as taking a screenshots on Mac). The issue here is that when the shift key was pressed, followed by 'command' in order to take a screenshot, the application was paused as it entered screenshot mode and
isShiftDown
in ouruseKeyDown
hook did not update on 'keyup'. The last captured event was 'keydown' of the shift key, thereforeisShiftDown
remained stuck in a 'down' state, even though it was no longer down. Manually resettingisShiftDown
state to false when the user hits the "Meta" key (in Mac = command, in Windows = Control) was able to solve this issue.Additionally, clicks outside of the tooltip have been disabled when shift is held down in order to ensure that only the tooltip can be clicked while the tooltip is frozen. This was able to resolve issues around unexpected zooming.