Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Added screen with info when no data is received on the server #2567

Merged
merged 6 commits into from
Feb 13, 2023

Conversation

manojVivek
Copy link
Contributor

Fixes #2514

Screenshot:
Screenshot_2023-02-09_at_1 08 01_PM

@manojVivek manojVivek requested a review from a team as a code owner February 9, 2023 11:18
return <>{loader}</>;
}

if (profileTypesData?.types.length === 1) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to confirm, do we only want to show the no data prompt when the length === 1? Would profileTypesData?.types.length ever return 0 or -1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, was using 1 for testing and pushing that too. 😐
Fixing it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When there is no data, modify the UI to show some pointers to check if the data ingestion is happening
2 participants