222 fix query #247
Merged
222 fix query #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thorfour
commented
Oct 6, 2021
| @@ -367,14 +367,14 @@ func (q *HeadQuerier) Select(hints *SelectHints, ms ...*labels.Matcher) SeriesSe | |||
|
|
|||
| ir, err := q.head.Index() | |||
| if err != nil { | |||
| return nil | |||
| return &SliceSeriesSet{} | |||
There was a problem hiding this comment.
We blindly assume that Select doesn't return nil, so I set these error cases to return an empty set instead.
thorfour
force-pushed
the
222-fix-query
branch
from
9fbdfbc to
e6f8cc1
Compare
Subsequent And operations from postingsForMatcher
can cause the bitmap to be empty, but doesn't mean it should be set to
the next result.
ex:
A: [1,2]
B: [maxuint64]
C: [1,2]
should result in an empty array
however if they are applied in order with the previous logic of
if bitmap.IsEmpty() {
bitmap = bm
} else {
bitmap.And(bm)
}
We'll see
bitmap = A [1,2]
bitmap = A & B = []
bitmap = C = [1,2]
which will return incorrect postings
thorfour
force-pushed
the
222-fix-query
branch
from
e6f8cc1 to
e8f5363
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the error in #222 by correctly handling matchers that produce a empty bitmap
Adds unit test to catch this behavior.