Address CI issues

Signed-off-by: Kemal Akkoyun <[email protected]>

Makefile

@@ -179,7 +179,7 @@ dev/up: deploy/manifests
 dev/down:
 	source ./scripts/local-dev.sh && down
 
-tmp/help.txt: build
+tmp/help.txt: go/bin
 	mkdir -p tmp
 	bin/parca --help > $@
 

README.md

@@ -90,7 +90,8 @@ Flags:
                                    to a remote gRPC endpoint. All runs all
                                    components.
       --log-level="info"           log level.
-      --port=":7070"               Port string for server
+      --http-address=":7070"       Address to bind HTTP server to.
+      --port=""                    (DEPRECATED) Use http-address instead.
       --cors-allowed-origins=CORS-ALLOWED-ORIGINS,...
                                    Allowed CORS origins.
       --otlp-address=STRING        OpenTelemetry collector address to send

proto/buf.lock

@@ -4,8 +4,8 @@ deps:
   - remote: buf.build
     owner: googleapis
     repository: googleapis
-    commit: d1263fe26f8e430a967dc22a4d0cad18
+    commit: 783e4b5374fa488ab068d08af9658438
   - remote: buf.build
     owner: grpc-ecosystem
     repository: grpc-gateway
-    commit: b96615cde70c403f8075c48e56178f88
+    commit: b98ae2f8ce63452e97e6bae65c5add1b

proto/parca/debuginfo/v1alpha1/debuginfo.proto

@@ -49,8 +49,8 @@ message UploadInfo {
   // hash is the hash of the source file that debug information extracted from
   string hash = 2;
 
-  // TODO(kakkoyun): Add SourceHash and use Hash as debuginfo file hash.
-  // TODO(kakkoyun): Add SourceType enum.
+// TODO(kakkoyun): Add SourceHash and use Hash as debuginfo file hash.
+// TODO(kakkoyun): Add SourceType enum.
 }
 
 // UploadResponse returns the build_id and the size of the uploaded debug info

proto/parca/profilestore/v1alpha1/profilestore.proto

@@ -66,7 +66,9 @@ message RawSample {
 service AgentsService {
   // Agents return the agents that pushed data to the server
   rpc Agents(AgentsRequest) returns (AgentsResponse) {
-    option (google.api.http) = {get: "/agents"};
+    option (google.api.http) = {
+      get: "/agents"
+    };
   }
 }
 

proto/parca/query/v1alpha1/query.proto

@@ -11,32 +11,44 @@ import "parca/profilestore/v1alpha1/profilestore.proto";
 service QueryService {
   // QueryRange performs a profile query over a time range
   rpc QueryRange(QueryRangeRequest) returns (QueryRangeResponse) {
-    option (google.api.http) = {get: "/profiles/query_range"};
+    option (google.api.http) = {
+      get: "/profiles/query_range"
+    };
   }
 
   // Query performs a profile query
   rpc Query(QueryRequest) returns (QueryResponse) {
-    option (google.api.http) = {get: "/profiles/query"};
+    option (google.api.http) = {
+      get: "/profiles/query"
+    };
   }
 
   // Series is unimplemented
   rpc Series(SeriesRequest) returns (SeriesResponse) {
-    option (google.api.http) = {get: "/profiles/series"};
+    option (google.api.http) = {
+      get: "/profiles/series"
+    };
   }
 
   // ProfileTypes returns the list of available profile types.
   rpc ProfileTypes(ProfileTypesRequest) returns (ProfileTypesResponse) {
-    option (google.api.http) = {get: "/profiles/types"};
+    option (google.api.http) = {
+      get: "/profiles/types"
+    };
   }
 
   // Labels returns the set of label names against a given matching string and time frame
   rpc Labels(LabelsRequest) returns (LabelsResponse) {
-    option (google.api.http) = {get: "/profiles/labels"};
+    option (google.api.http) = {
+      get: "/profiles/labels"
+    };
   }
 
   // Values returns the set of values that match a given label and time frame
   rpc Values(ValuesRequest) returns (ValuesResponse) {
-    option (google.api.http) = {get: "/profiles/labels/{label_name}/values"};
+    option (google.api.http) = {
+      get: "/profiles/labels/{label_name}/values"
+    };
   }
 
   // ShareProfile uploads the given profile to pprof.me and returns a link to the profile.

proto/parca/scrape/v1alpha1/scrape.proto

@@ -11,7 +11,9 @@ import "parca/profilestore/v1alpha1/profilestore.proto";
 service ScrapeService {
   // Targets returns the set of scrape targets that are configured
   rpc Targets(TargetsRequest) returns (TargetsResponse) {
-    option (google.api.http) = {get: "/targets"};
+    option (google.api.http) = {
+      get: "/targets"
+    };
   }
 }
 

ui/packages/shared/client/src/google/protobuf/descriptor.ts

@@ -277,6 +277,7 @@ export interface FieldDescriptorProto {
      * For booleans, "true" or "false".
      * For strings, contains the default text contents (not escaped in any way).
      * For bytes, contains the C escaped value.  All bytes >= 128 are escaped.
+     * TODO(kenton):  Base-64 encode?
      *
      * @generated from protobuf field: optional string default_value = 7;
      */
@@ -978,23 +979,9 @@ export interface FieldOptions {
      * check its required fields, regardless of whether or not the message has
      * been parsed.
      *
-     * As of 2021, lazy does no correctness checks on the byte stream during
-     * parsing.  This may lead to crashes if and when an invalid byte stream is
-     * finally parsed upon access.
-     *
-     * TODO(b/211906113):  Enable validation on lazy fields.
-     *
      * @generated from protobuf field: optional bool lazy = 5;
      */
     lazy?: boolean;
-    /**
-     * unverified_lazy does no correctness checks on the byte stream. This should
-     * only be used where lazy with verification is prohibitive for performance
-     * reasons.
-     *
-     * @generated from protobuf field: optional bool unverified_lazy = 15;
-     */
-    unverifiedLazy?: boolean;
     /**
      * Is this field deprecated?
      * Depending on the target platform, this can emit Deprecated annotations
@@ -1243,8 +1230,8 @@ export interface UninterpretedOption {
  * The name of the uninterpreted option.  Each string represents a segment in
  * a dot-separated name.  is_extension is true iff a segment represents an
  * extension (denoted with parentheses in options specs in .proto files).
- * E.g.,{ ["foo", false], ["bar.baz", true], ["moo", false] } represents
- * "foo.(bar.baz).moo".
+ * E.g.,{ ["foo", false], ["bar.baz", true], ["qux", false] } represents
+ * "foo.(bar.baz).qux".
  *
  * @generated from protobuf message google.protobuf.UninterpretedOption.NamePart
  */
@@ -1326,8 +1313,8 @@ export interface SourceCodeInfo_Location {
      * location.
      *
      * Each element is a field number or an index.  They form a path from
-     * the root FileDescriptorProto to the place where the definition occurs.
-     * For example, this path:
+     * the root FileDescriptorProto to the place where the definition.  For
+     * example, this path:
      *   [ 4, 3, 2, 7, 1 ]
      * refers to:
      *   file.message_type(3)  // 4, 3
@@ -1387,13 +1374,13 @@ export interface SourceCodeInfo_Location {
      *   // Comment attached to baz.
      *   // Another line attached to baz.
      *
-     *   // Comment attached to moo.
+     *   // Comment attached to qux.
      *   //
-     *   // Another line attached to moo.
-     *   optional double moo = 4;
+     *   // Another line attached to qux.
+     *   optional double qux = 4;
      *
      *   // Detached comment for corge. This is not leading or trailing comments
-     *   // to moo or corge because there are blank lines separating it from
+     *   // to qux or corge because there are blank lines separating it from
      *   // both.
      *
      *   // Detached comment for corge paragraph 2.
@@ -2694,7 +2681,6 @@ class FieldOptions$Type extends MessageType<FieldOptions> {
             { no: 2, name: "packed", kind: "scalar", opt: true, T: 8 /*ScalarType.BOOL*/ },
             { no: 6, name: "jstype", kind: "enum", opt: true, T: () => ["google.protobuf.FieldOptions.JSType", FieldOptions_JSType] },
             { no: 5, name: "lazy", kind: "scalar", opt: true, T: 8 /*ScalarType.BOOL*/ },
-            { no: 15, name: "unverified_lazy", kind: "scalar", opt: true, T: 8 /*ScalarType.BOOL*/ },
             { no: 3, name: "deprecated", kind: "scalar", opt: true, T: 8 /*ScalarType.BOOL*/ },
             { no: 10, name: "weak", kind: "scalar", opt: true, T: 8 /*ScalarType.BOOL*/ },
             { no: 999, name: "uninterpreted_option", kind: "message", repeat: 2 /*RepeatType.UNPACKED*/, T: () => UninterpretedOption }
@@ -2724,9 +2710,6 @@ class FieldOptions$Type extends MessageType<FieldOptions> {
                 case /* optional bool lazy */ 5:
                     message.lazy = reader.bool();
                     break;
-                case /* optional bool unverified_lazy */ 15:
-                    message.unverifiedLazy = reader.bool();
-                    break;
                 case /* optional bool deprecated */ 3:
                     message.deprecated = reader.bool();
                     break;
@@ -2760,9 +2743,6 @@ class FieldOptions$Type extends MessageType<FieldOptions> {
         /* optional bool lazy = 5; */
         if (message.lazy !== undefined)
             writer.tag(5, WireType.Varint).bool(message.lazy);
-        /* optional bool unverified_lazy = 15; */
-        if (message.unverifiedLazy !== undefined)
-            writer.tag(15, WireType.Varint).bool(message.unverifiedLazy);
         /* optional bool deprecated = 3; */
         if (message.deprecated !== undefined)
             writer.tag(3, WireType.Varint).bool(message.deprecated);