Incompatibility between ParaTest 7.3.1 and PHPUnit ^10.5.38 on PHP 8.1 #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Environment
📄 Summary
Starting from PHPUnit 10.5.32, a new flag failOnPhpunitDeprecation was introduced (see PHPUnit Issue #5937).
This version of PHPUnit is available for PHP 8.1, but ParaTest only added support for this flag for PHP > 8.2.
As a result, the following error occurs when running ParaTest with PHPUnit 10.5.38 on PHP 8.1:
PHP Fatal error: Uncaught TypeError: PHPUnit\TextUI\ShellExitCodeCalculator::calculate(): Argument #8 ($failOnWarning) must be of type bool, PHPUnit\TestRunner\TestResult\TestResult given, called in .../vendor/brianium/paratest/src/WrapperRunner/WrapperRunner.php on line 296 and defined in .../vendor/phpunit/phpunit/src/TextUI/ShellExitCodeCalculator.php:25If there is anything wrong with the way I structured this pr or if you need more information, please let me know, and I’ll be happy to update it.