Fix LogMerger when no log is created
#867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When thare are no tests to run, the `LogMerger` crashes on the last test (`assert($mainSuite !== null);`), because there are no log files generated to merge together. With this initial check in the WrapperRunner, we only try to merge the log files if there are actually created log files. The list with junitFiles is populated with a SplFileObject for every process/thread it will be running on, but none of the temp files are actually generated/written.
|
Hi, can you add a test please? |
I tried it. The single test works fine. But I can't get the whole suite working without errors locally. Hopefully it works fine in the workflow here 🙈. |
|
Perfect, thank you
That's on me, you did good 👍 |
Slamdunk
changed the title
LogMerger when no log is created
Slamdunk
pushed a commit
to Slamdunk/paratest
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When thare are no tests to run, the
LogMergercrashes on the last test (assert($mainSuite !== null);), because there are no log files generated to merge together. With this initial check in the WrapperRunner, we only try to merge the log files if there are actually created log files. The list with junitFiles is populated with a SplFileObject for every process/thread it will be running on, but none of the temp files are actually generated/written.