Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to wgpu 0.10 #187

Merged
merged 4 commits into from
Sep 1, 2021
Merged

Update to wgpu 0.10 #187

merged 4 commits into from
Sep 1, 2021

Conversation

parasyte
Copy link
Owner

@parasyte parasyte commented Aug 31, 2021

- It would be nice to return an error from the render function
- imgui-winit is still a WIP (open PR: Yatekii/imgui-wgpu-rs#66)
- minimal-fltk flashes wildly! :(
@parasyte
Copy link
Owner Author

parasyte commented Aug 31, 2021

Just so I don't forget: I need to verify if pixels.surface_size is still necessary. The new wgpu::SurfaceConfiguration basically has the same information as our Surface struct (IIRC). We might be able to trim some fat!

Also need to remove all references to "swap chain", and consider adding SurfaceConfiguration to PixelsContext instead of recreating it every time.

@MoAlyousef
Copy link
Contributor

Hi
Thanks for this. Regarding the fltk example, can you try replacing the:

        win.redraw();

        // Calls to redraw in the event loop require an explicit sleep
        thread::sleep(Duration::from_millis(SLEEP));

part of the loop with:

        app::flush();
        app::awake();

This seems to resolve the issue of flashing for me on Windows.

@parasyte
Copy link
Owner Author

Thanks for the suggestion! I'll give this a shot tomorrow when I get back to resolving the other remaining issues.

@parasyte parasyte mentioned this pull request Sep 1, 2021
@parasyte
Copy link
Owner Author

parasyte commented Sep 1, 2021

Just converted a project over to this branch and it was a drop-in replacement. I think this is good to go.

... I'll address the imgui-winit example in another PR.

@parasyte parasyte merged commit e08c91b into master Sep 1, 2021
@parasyte parasyte deleted the update-wgpu-0.10 branch September 1, 2021 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WGPU 0.10
2 participants