Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve/auto compound #384

Closed
wants to merge 32 commits into from
Closed

Improve/auto compound #384

wants to merge 32 commits into from

Conversation

0x8f701
Copy link
Contributor

@0x8f701 0x8f701 commented May 5, 2023

Security Checklist

  • 1. Re-Entrancy
  • 2. Arithmetic Over/Under Flows
  • 3. Unexpected Ether
  • 4. Delegatecall
  • 5. Default Visibilities
  • 6. Entropy Illusion
  • 7. External Contract Referencing
  • 8. Short Address/Parameter Attack (off chain)
  • 9. Unchecked CALL Return Values
  • 10. Race Conditions / Front Running
  • 11. Denial Of Service (DOS)
  • 12. Block Timestamp Manipulation
  • 13. Constructors with Care
  • 14. Uninitialized Storage Pointers
  • 15. Floating Points and Precision
  • 16. Tx.Origin Authentication
  • 17. Address.isContract Re-Entrancy via Constructor

⚠️ NOTES ⚠️

Make sure to think about each of these exploits in this PR.

@0x8f701 0x8f701 requested a review from a team as a code owner May 5, 2023 02:56
0x8f701 added 21 commits May 6, 2023 08:41
@0x8f701
feat: seperate compoundBot & matchingOperator
35f9863 
Signed-off-by: GopherJ <[email protected]>
@0x8f701
feat: put slippage offchain
807b966 
Signed-off-by: GopherJ <[email protected]>
@0x8f701
fix: lint
7b42745 
Signed-off-by: GopherJ <[email protected]>
@0x8f701
fix: typo
6e1c2dd 
Signed-off-by: GopherJ <[email protected]>
@0x8f701
chore: gas optimize
c686c37 
Signed-off-by: GopherJ <[email protected]>
@0x8f701
fix: gas optimize
cc60418 
Signed-off-by: GopherJ <[email protected]>
@0x8f701
fix: check swapAmount before transfer
4270ed3 
Signed-off-by: GopherJ <[email protected]>
@0x8f701
fix: part of tests
a174e33 
Signed-off-by: GopherJ <[email protected]>
@0x8f701
fix: auto compound tests
ec2dc1c 
Signed-off-by: GopherJ <[email protected]>
@0x8f701
chore: cleanup
b6a3b37 
Signed-off-by: GopherJ <[email protected]>
@0x8f701
fix: remove unused bot params
ffef685 
Signed-off-by: GopherJ <[email protected]>
@0x8f701
fix: increase precision
4f21916 
Signed-off-by: GopherJ <[email protected]>
@0x8f701
chore: use real price
a372a1a 
Signed-off-by: GopherJ <[email protected]>
@0x8f701
chore: use swapPercent instead
5980e00 
Signed-off-by: GopherJ <[email protected]>
@0x8f701
Merge branch 'main' into improve/auto-compound
0d81db9
@0x8f701
chore: update verify docs & add shelljs
c33aee9 
Signed-off-by: GopherJ <[email protected]>
@0x8f701
Merge remote-tracking branch 'origin/main' into improve/auto-compound
f03f9c7
@0x8f701
chore: update submodules
922e77a 
Signed-off-by: GopherJ <[email protected]>
@0x8f701
chore: add safe owner interface
3a3f074 
Signed-off-by: GopherJ <[email protected]>
@0x8f701
chore: use https for ethereumjs-abi
52ca0b2 
Signed-off-by: GopherJ <[email protected]>
@0x8f701
chore: try fix ci
734ae74 
Signed-off-by: GopherJ <[email protected]>
@0x8f701 0x8f701 requested a review from a team as a code owner May 16, 2023 08:46
zhoujia6139
zhoujia6139 previously approved these changes May 19, 2023
View reviewed changes
0x8f701 added 6 commits July 11, 2023 18:27
@0x8f701
fix: uniswap tests
f29a407 
Signed-off-by: GopherJ <[email protected]>
@0x8f701
fix: tests
a4781a8 
Signed-off-by: GopherJ <[email protected]>
@0x8f701
Merge branch 'improve/auto-compound' of ssh://github.com/para-space/p…
d6db1ef 
…araspace-core into improve/auto-compound
@0x8f701
chore: update readme
0b3214f 
Signed-off-by: GopherJ <[email protected]>
@0x8f701
chore: update lockfile
89f0fbf 
Signed-off-by: GopherJ <[email protected]>
@0x8f701
fix: lint
97aba24 
Signed-off-by: GopherJ <[email protected]>
@zhoujia6139
Copy link
Contributor

Changes merged to #403

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhoujia6139 zhoujia6139 zhoujia6139 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0x8f701 @zhoujia6139