Add BasicClient to ParsecToolApp #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hug-dev
reviewed
Feb 5, 2021
src/main.rs
Outdated
| matches.init_client().map_err(|e| { | ||
| err!("{:?}", e); | ||
| std::io::Error::new(std::io::ErrorKind::Other, "Spinning up BasicClient failed.") | ||
| })?; | ||
| matches.subcommand.run(&matches).map_err(|e| { |
There was a problem hiding this comment.
I think it's very good to spin up the BasicClient before but couldn't it be cleaner if we do it directly in the main function and pass the reference to the run method? It seems cleaner than having it in the structopt structure, even though we can skip it. That way we keep both things separate (CLI and client)
There was a problem hiding this comment.
Sure, that works for me - we can pass the whole client like that, not just a reference, since we only run one subcommand anyway. I'll update
This commit changes the Subcommand trait to accept a BasicClient when the command is run. The client can then be freely used during the subcommand processing. Signed-off-by: Ionut Mihalcea <[email protected]>
ionut-arm
force-pushed
the
basic-client
branch
from
5f33673 to
f1522d9
Compare
hug-dev
approved these changes
Feb 5, 2021
| use structopt::StructOpt; | ||
|
|
||
| fn main() -> std::io::Result<()> { | ||
| env_logger::init(); | ||
|
|
||
| let matches = cli::ParsecToolApp::from_args(); | ||
| matches.subcommand.run(&matches).map_err(|e| { | ||
| let client = BasicClient::new(matches.app_name.clone()).map_err(|e| { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an instance of BasicClient to the ParsecToolApp so that
all subcommands can simply use this one instead of spinning up their
own.
Signed-off-by: Ionut Mihalcea [email protected]