-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the generate and destroy key operations #13
Conversation
fn try_from( | ||
psa_generate_key_subcommand: &PsaGenerateKeySubcommand, | ||
) -> Result<NativeOperation, Self::Error> { | ||
Ok(NativeOperation::PsaGenerateKey( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's worth adding a // FIXME
or // TODO
here to signify that there are currently no options for controlling which kind of key gets generated, but not a blocker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, done!
} | ||
}; | ||
|
||
Ok(()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested this locally -- could we get some text confirmation that the key has been created successfully? 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, done 🚀 !
The key generation currently hardcodes it to 2048 RSA. Signed-off-by: Hugues de Valon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, feel free to disregard the comment below.
sign_hash: true, | ||
..Default::default() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity - you don't want to be able to verify? I guess you can export public key and re-import it and verify with that, but it seems like a faff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, this is just to create a key but not use it with the tool, just to be able to list it and delete it 😄 We can modify this later!
The Generate key one currently hardcodes the key to 2048 bits RSA to make it easier to use on the CLI.
I tested it and it works well 😄
Will rebase on top of the other PR once merged.