Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some commands should not need authentication #49

Closed
hug-dev opened this issue Mar 15, 2021 · 0 comments
Closed

Some commands should not need authentication #49

hug-dev opened this issue Mar 15, 2021 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers medium Effort label

Comments

@hug-dev
Copy link
Member

hug-dev commented Mar 15, 2021

Some commands:

  • Ping
  • ListProviders
  • ListOpcodes
  • ListAuthenticators

should not need an authenticator. At the moment they do because they are executed through the BasicClient which does automatic authenticator selection.

Maybe the automatic authenticator selection should only be done in the Subcommand::run method for the subcommands that need it.
@hug-dev hug-dev added bug Something isn't working medium Effort label labels Mar 15, 2021
@hug-dev hug-dev added the good first issue Good for newcomers label Apr 29, 2021
jn9e9 added a commit to jn9e9/parsec-tool that referenced this issue Nov 8, 2021
@jn9e9
fix parallaxsecond#49
641a5b2 
Signed-off-by: John 9e9 <[email protected]>
This was referenced Nov 9, 2021
Open
Merged
ionut-arm added a commit that referenced this issue Nov 10, 2021
@ionut-arm
Merge pull request #65 from jn9e9/jn9e9/issue49
84eadc1 
fix #49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers medium Effort label
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hug-dev