Fixed basic.html and updated 'pdfjsnewwindow' #2855
Conversation
| @@ -3026,7 +3026,7 @@ function jsPDF(options) { | |||
| "<style>html, body { padding: 0; margin: 0; } iframe { width: 100%; height: 100%; border: 0;} </style>" + | |||
| '<body><iframe id="pdfViewer" src="' + | |||
| pdfJsUrl + | |||
| '?file=" width="500px" height="400px" />' + | |||
| '?file=&downloadName=' + options.filename + '" width="500px" height="400px" />' + | |||
There was a problem hiding this comment.
The arguments seem a little messed up now...
There was a problem hiding this comment.
This is the only way so far that I can think of to pass the file name for download using pdf.js. Currently, it defaults to "ducment.pdf". The arguments in viewer.js seem always has only one element - the blob URL, so it's not useful for that matter.
There was a problem hiding this comment.
Yeah, that's alright. It's just that the URL parameters now look like this
?file=&downloadName=filename.pdf
which looks a bit broken. Do you know what the "file=" part does? Seems to me like we can remove that part.
There was a problem hiding this comment.
Actually file= is required, it provides the PDF file for rendering. Normally it would be ?file=/folder/test.pdf. Here it is blank and I think the pdf content is populated by bloburl instead. I tried to remove it, but ?downloadName=filename.pdf returns error:
There was a problem hiding this comment.
Ah, ok. Didn't test it. Then everything is fine ;)
There was a problem hiding this comment.
Thanks! Just for the record, it passes the bloburl as the file name to pdf.js first, then replaces it with a physical pdf file name/path if exists. How the bloburl is inserted as the file name is not clear to me yet.
|
Restarting once again... hope it will work this time... |
Fixed basic.html to work with the new release;
Updated output('pdfjsnewwindow') to allow user-defined title and download file name