Fix variable names to match ext/sodium #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is technically an API break for PHP 8 projects. However, this polyfill always targeted PHP 5, 7.0, and 7.1. You shouldn't need it on 7.2+. The end result of this change is that you should be able to write code that uses named parameters on PHP 8 and have it work regardless of ext/sodium being installed or not (provided you import sodium_compat via composer). Additionally, we include lib/ in the psalm checks (if applicable). This will need a new minor version (v1.19.0).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is technically an API break for PHP 8 projects. However, this polyfill always targeted PHP 5, 7.0, and 7.1. You shouldn't need it on 7.2+.
The end result of this change is that you should be able to write code that uses named parameters on PHP 8 and have it work regardless of ext/sodium being installed or not (provided you import sodium_compat via composer).
Additionally, we include lib/ in the psalm checks (if applicable).
This will need a new minor version (v1.19.0).