Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move reputation types from reth-network-api to reth-network-types #9914

Merged
merged 4 commits into from
Jul 31, 2024
Merged

Move reputation types from reth-network-api to reth-network-types #9914

merged 4 commits into from
Jul 31, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Jul 30, 2024 •
edited
Loading

Fixes dependency reth-network-api -> reth-network-types

This is a blocker for #9872 and in general we want to follow pattern that types crate doesn't depend on api crate

@emhane emhane added C-debt A clean up/refactor of existing code A-networking Related to networking in general labels Jul 30, 2024
mattsse
mattsse requested changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can avoid updating a ton of imports by re-exporting reputation types, which is reasonable because part of public network-api traits functions

@emhane emhane enabled auto-merge July 31, 2024 19:55
@emhane emhane added this pull request to the merge queue Jul 31, 2024
Merged via the queue into main with commit 78703b5 Jul 31, 2024
33 checks passed
@emhane emhane deleted the emhane/network-types branch July 31, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-networking Related to networking in general C-debt A clean up/refactor of existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emhane @mattsse