Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(trie): allow supplying prefix sets to Proof #9317

Merged
merged 3 commits into from
Jul 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions crates/trie/trie/src/prefix_set/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,15 @@ impl PrefixSetMut {
self.keys.push(nibbles);
}

/// Extend prefix set keys with contents of provided iterator.
pub fn extend<I>(&mut self, nibbles_iter: I)
where
I: IntoIterator<Item = Nibbles>,
{
self.sorted = false;
self.keys.extend(nibbles_iter);
}

/// Returns the number of elements in the set.
pub fn len(&self) -> usize {
self.keys.len()
Expand Down
26 changes: 18 additions & 8 deletions crates/trie/trie/src/proof.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
use crate::{
hashed_cursor::{HashedCursorFactory, HashedStorageCursor},
node_iter::{TrieElement, TrieNodeIter},
prefix_set::PrefixSetMut,
prefix_set::TriePrefixSetsMut,
trie_cursor::{DatabaseAccountTrieCursor, DatabaseStorageTrieCursor},
walker::TrieWalker,
HashBuilder, Nibbles,
Expand All @@ -24,23 +24,31 @@ pub struct Proof<'a, TX, H> {
tx: &'a TX,
/// The factory for hashed cursors.
hashed_cursor_factory: H,
/// A set of prefix sets that have changes.
prefix_sets: TriePrefixSetsMut,
}

impl<'a, TX, H> Proof<'a, TX, H> {
/// Creates a new proof generator.
pub const fn new(tx: &'a TX, hashed_cursor_factory: H) -> Self {
Self { tx, hashed_cursor_factory }
pub fn new(tx: &'a TX, hashed_cursor_factory: H) -> Self {
Self { tx, hashed_cursor_factory, prefix_sets: TriePrefixSetsMut::default() }
}

/// Set the hashed cursor factory.
pub fn with_hashed_cursor_factory<HF>(self, hashed_cursor_factory: HF) -> Proof<'a, TX, HF> {
Proof { tx: self.tx, hashed_cursor_factory }
Proof { tx: self.tx, hashed_cursor_factory, prefix_sets: self.prefix_sets }
}

/// Set the prefix sets. They have to be mutable in order to allow extension with proof target.
pub fn with_prefix_sets_mut(mut self, prefix_sets: TriePrefixSetsMut) -> Self {
self.prefix_sets = prefix_sets;
self
}
}

impl<'a, TX> Proof<'a, TX, &'a TX> {
/// Create a new [Proof] instance from database transaction.
pub const fn from_tx(tx: &'a TX) -> Self {
pub fn from_tx(tx: &'a TX) -> Self {
Self::new(tx, tx)
}
}
Expand All @@ -65,7 +73,7 @@ where
DatabaseAccountTrieCursor::new(self.tx.cursor_read::<tables::AccountsTrie>()?);

// Create the walker.
let mut prefix_set = PrefixSetMut::default();
let mut prefix_set = self.prefix_sets.account_prefix_set.clone();
prefix_set.insert(target_nibbles.clone());
let walker = TrieWalker::new(trie_cursor, prefix_set.freeze());

Expand Down Expand Up @@ -130,12 +138,14 @@ where
}

let target_nibbles = proofs.iter().map(|p| p.nibbles.clone()).collect::<Vec<_>>();
let prefix_set = PrefixSetMut::from(target_nibbles.clone()).freeze();
let mut prefix_set =
self.prefix_sets.storage_prefix_sets.get(&hashed_address).cloned().unwrap_or_default();
prefix_set.extend(target_nibbles.clone());
let trie_cursor = DatabaseStorageTrieCursor::new(
self.tx.cursor_dup_read::<tables::StoragesTrie>()?,
hashed_address,
);
let walker = TrieWalker::new(trie_cursor, prefix_set);
let walker = TrieWalker::new(trie_cursor, prefix_set.freeze());

let retainer = ProofRetainer::from_iter(target_nibbles);
let mut hash_builder = HashBuilder::default().with_proof_retainer(retainer);
Expand Down
Loading