Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure to commit static file provider on stage run #8972

Merged
merged 2 commits into from
Jun 19, 2024
Merged

fix: make sure to commit static file provider on stage run #8972

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b5ba64
make sure to commit static file on stage run
joshieDo Jun 19, 2024
eaba4a3
add docs
joshieDo Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion bin/reth/src/commands/stage/run.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ use reth_config::config::{HashingConfig, SenderRecoveryConfig, TransactionLookup
use reth_downloaders::bodies::bodies::BodiesDownloaderBuilder;
use reth_exex::ExExManagerHandle;
use reth_provider::{
ChainSpecProvider, StageCheckpointReader, StageCheckpointWriter, StaticFileProviderFactory,
ChainSpecProvider, StageCheckpointReader, StageCheckpointWriter, StaticFileProviderFactory, StaticFileWriter,
};
use reth_stages::{
stages::{
Expand Down Expand Up @@ -254,6 +254,7 @@ impl Command {

if self.commit {
provider_rw.commit()?;
provider_factory.static_file_provider().commit()?;
provider_rw = provider_factory.provider_rw()?;
}
}
Expand All @@ -276,6 +277,7 @@ impl Command {
provider_rw.save_stage_checkpoint(exec_stage.id(), checkpoint)?;
}
if self.commit {
provider_factory.static_file_provider().commit()?;
provider_rw.commit()?;
provider_rw = provider_factory.provider_rw()?;
}
Expand Down
Loading