Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move Header and SealedHeader to reth-primitives-traits #8831

Merged
merged 3 commits into from
Jun 14, 2024

Conversation

joshieDo
Copy link
Collaborator

re: #8748

Should unblock #8055

@joshieDo joshieDo added the C-debt A clean up/refactor of existing code label Jun 14, 2024
@joshieDo joshieDo requested a review from mattsse June 14, 2024 12:56
@joshieDo joshieDo marked this pull request as ready for review June 14, 2024 12:59
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice,

we need to do this because this is shared for all networks we support rn.

@joshieDo joshieDo enabled auto-merge June 14, 2024 14:02
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joshieDo joshieDo added this pull request to the merge queue Jun 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jun 14, 2024
@joshieDo joshieDo added this pull request to the merge queue Jun 14, 2024
Merged via the queue into main with commit 217ff95 Jun 14, 2024
31 checks passed
@joshieDo joshieDo deleted the joshie/header-trait branch June 14, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt A clean up/refactor of existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants