Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: disable default features for alloy workspace deps #8768

Merged
merged 5 commits into from
Jun 13, 2024
Merged

refactor: disable default features for alloy workspace deps #8768

merged 5 commits into from
Jun 13, 2024

Conversation

TropicalDog17
Copy link
Contributor

@TropicalDog17 TropicalDog17 commented Jun 12, 2024

Description

disable default features for alloy workspace dependencies, and enable required features.

Closes #8765

/cc @mattsse @gakonst

@TropicalDog17 TropicalDog17 requested a review from gakonst as a code owner June 12, 2024 06:44
@shekhirin shekhirin added the C-debt A clean up/refactor of existing code label Jun 12, 2024
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending conflicts

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending @mattsse suggestions, the feature clarifications make sense

@TropicalDog17 TropicalDog17 requested a review from mattsse June 13, 2024 02:25
@onbjerg onbjerg enabled auto-merge June 13, 2024 13:43
@onbjerg onbjerg added this pull request to the merge queue Jun 13, 2024
Merged via the queue into paradigmxyz:main with commit 41933b7 Jun 13, 2024
29 checks passed
@TropicalDog17 TropicalDog17 deleted the tuan/disable-default-features-alloy branch June 16, 2024 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt A clean up/refactor of existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

disable default features for alloy workspace deps
6 participants