chore: move proof types and root functions from primitives/proofs into reth-trie-common
#8724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshieDo
requested review from
rkrasiuk,
Rjected,
rakita,
shekhirin,
mattsse,
DaniPopes and
gakonst
as code owners
joshieDo
commented
Jun 10, 2024
mattsse
requested changes
Jun 10, 2024
There was a problem hiding this comment.
we should think about the dep graph a bit more before we rush this and introduce generics due to dependencies.
atm we have two kinds of primitive types:
- lower level types that are shared by OP and Eth, for example Account
- types that are different: Transaction/Receipt
perhaps a more reasonable approach is:
isolate 1. first (I'm fine if we temporarily moving these to the primitives-traits as well)
primitives-traits will then eventually become the new primitives
| @@ -0,0 +1,117 @@ | |||
| //! Common root computation functions. | |||
rkrasiuk
approved these changes
Jun 13, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8674
reth-trie-typestoreth-trie-commonprimitives/proofstoreth-trie-common(this is the reason for the crate renaming)AccountProofandStorageProofintoreth-trie-commonby usingreth-primitives-traits::Account.