Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add secp256k1 feature in reth-network-peers #8712

Merged
merged 5 commits into from
Jun 10, 2024
Merged

feat: add secp256k1 feature in reth-network-peers #8712

merged 5 commits into from
Jun 10, 2024

Conversation

PanGan21
Copy link
Contributor

@PanGan21 PanGan21 commented Jun 9, 2024 •
edited by onbjerg
Loading

  • Adds secp256k1 feature to reth-network-peers crate
  • Disables default features in workspace for reth-network-peers
  • Enables secp256k1 for reth-network-peers crate in reth-ecies, reth-discv4,reth-discv5, reth-dns-discovery crates

Closes #8700

@PanGan21 PanGan21 mentioned this pull request Jun 9, 2024
Closed
onbjerg
onbjerg approved these changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@onbjerg onbjerg added the C-debt A clean up/refactor of existing code label Jun 10, 2024
@onbjerg onbjerg changed the title feat-8700: add secp256k1 feature in reth-network-peers feat: add secp256k1 feature in reth-network-peers Jun 10, 2024
@onbjerg onbjerg added C-enhancement New feature or request A-networking Related to networking in general and removed C-debt A clean up/refactor of existing code labels Jun 10, 2024
mattsse
mattsse approved these changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

@mattsse mattsse enabled auto-merge June 10, 2024 11:33
@mattsse mattsse added this pull request to the merge queue Jun 10, 2024
Merged via the queue into paradigmxyz:main with commit 8717ed7 Jun 10, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

@mattsse mattsse mattsse approved these changes

@emhane emhane Awaiting requested review from emhane

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-networking Related to networking in general C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature gate secp256k1 in reth-network-peers
3 participants
@PanGan21 @onbjerg @mattsse