Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove Bandwidthmeter type #8698

Merged
merged 6 commits into from
Jun 9, 2024
Merged

feat: remove Bandwidthmeter type #8698

merged 6 commits into from
Jun 9, 2024

Conversation

kamuik16
Copy link
Contributor

@kamuik16 kamuik16 commented Jun 9, 2024

Closes #8643

@kamuik16
Copy link
Contributor Author

kamuik16 commented Jun 9, 2024

will mark ready for review after refactoring tests.

@mattsse mattsse added the A-networking Related to networking in general label Jun 9, 2024
@kamuik16 kamuik16 marked this pull request as ready for review June 9, 2024 09:48
@kamuik16
Copy link
Contributor Author

kamuik16 commented Jun 9, 2024

ready for review. cc @mattsse @Rjected @emhane.

mattsse
mattsse requested changes Jun 9, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

the meteredstream no longer does any metering and we can remove this

crates/net/common/src/bandwidth_meter.rs Outdated Show resolved Hide resolved
@kamuik16 kamuik16 requested a review from gakonst as a code owner June 9, 2024 12:55
@kamuik16 kamuik16 requested a review from mattsse June 9, 2024 12:56
@kamuik16
Copy link
Contributor Author

kamuik16 commented Jun 9, 2024

@mattsse, removed MeteredStream. ready for review.

mattsse
mattsse approved these changes Jun 9, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet! tysm

@mattsse mattsse added this pull request to the merge queue Jun 9, 2024
@kamuik16
Copy link
Contributor Author

kamuik16 commented Jun 9, 2024

sweet! tysm

the merge queue is complaining about merge conflicts, i think it's cargo update pr. wdyt?

@mattsse
Copy link
Collaborator

mattsse commented Jun 9, 2024 •
edited
Loading

resolved conflicts

@mattsse
Copy link
Collaborator

mattsse commented Jun 9, 2024

ah, there's a pr in the queue that introduces conflicts,
will resolve once merged

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jun 9, 2024
@mattsse mattsse enabled auto-merge June 9, 2024 13:29
@mattsse mattsse added this pull request to the merge queue Jun 9, 2024
Merged via the queue into paradigmxyz:main with commit c7fd507 Jun 9, 2024
30 checks passed
@kamuik16 kamuik16 deleted the remove-bandwidthmeter-type branch June 9, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@emhane emhane Awaiting requested review from emhane

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-networking Related to networking in general
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove Bandwidthmeter type
2 participants
@kamuik16 @mattsse