chore(rpc): EthTransactions default trait methods using pending block
#8659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
added
A-rpc
|
blocked by #8640 |
mattsse
approved these changes
Jun 7, 2024
| @@ -41,7 +41,7 @@ impl<Eth> EthBundle<Eth> { | |||
|
|
|||
| impl<Eth> EthBundle<Eth> | |||
| where | |||
| Eth: EthTransactions + LoadState + SpawnBlocking + 'static, | |||
| Eth: EthTransactions + LoadState + SpawnBlocking + LoadPendingBlock + 'static, | |||
There was a problem hiding this comment.
I could see the value in stacking them via utility traits, but we can do that later
There was a problem hiding this comment.
agreed, like for the provider interface. the provider interface is awesome, using it is good devx.
Base automatically changed from
emhane/ethapi-pending-block
to
matt/scaffold-ethapi
June 8, 2024 15:55
emhane
removed
the
S-blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves
EthTransactionsimpl onEthApi, that uses pending block, to default trait methods