Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Introduce payload primitives #8642

Merged
merged 9 commits into from Jun 6, 2024
Merged

feat: Introduce payload primitives #8642

merged 9 commits into from Jun 6, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jun 6, 2024 •
edited by ghost
Loading

Continue #8369
Ref: #8330

@ghost ghost requested review from mattsse, Rjected, onbjerg, rkrasiuk and gakonst as code owners June 6, 2024 13:46
mattsse
mattsse requested changes Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this restructuring.

in order to complete the original idea, we'd like to rollout the payloadtypes trait.

I'd like to keep this pr limited to the introduction of the primitives crate and move away from engine types in a followup pr

@mattsse mattsse changed the title WIP: Introduce payload primitives feat: Introduce payload primitives Jun 6, 2024
@mattsse mattsse added the A-block-building Related to block building label Jun 6, 2024
@ghost ghost requested a review from fgimenez as a code owner June 6, 2024 16:56
@ghost ghost requested a review from mattsse June 6, 2024 21:31
mattsse
mattsse approved these changes Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nextup Payloadtypes

@mattsse mattsse added this pull request to the merge queue Jun 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 6, 2024
@mattsse mattsse enabled auto-merge June 6, 2024 23:04
@mattsse mattsse added this pull request to the merge queue Jun 6, 2024
Merged via the queue into paradigmxyz:main with commit c362fc6 Jun 6, 2024
30 checks passed
@ghost ghost deleted the introduce-payload-primitives branch June 7, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

Assignees
No one assigned
Labels
A-block-building Related to block building
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mattsse