chore(rpc): default trait methods EthTransactions
#8639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
added
A-rpc
This was referenced Jun 6, 2024
mattsse
requested changes
Jun 6, 2024
mattsse
approved these changes
Jun 7, 2024
| TransactionSource, | ||
| }; | ||
| use std::sync::Arc; | ||
|
|
There was a problem hiding this comment.
removing the whitespace makes fmt order the std deps alphabetically with the other deps. I think it's very helpful to see which std deps are used easily by having it up top. kind of, in order of generality, since std lib is dep of most other deps.
use std::*;
use reth_dep::*;
use crate::*;
use super::*;| /// Returns a handle for reading evm config. | ||
| /// | ||
| /// Data access in default (L1) trait method implementations. | ||
| fn evm_config(&self) -> &impl ConfigureEvm; |
There was a problem hiding this comment.
I'd also like to auto_impl for & if possible
There was a problem hiding this comment.
it's not possible, but not because atuo_impl fails (which is the case for SpawnBlocking, which has methods taking a closure with Self as arg). I get this error, which I have a hunch is related to this rust-lang/rust#100013, since ConfigureEvm trait uses GAT of specific lifetime.
error: lifetime may not live long enough
--> crates/rpc/rpc/src/eth/api/transactions.rs:80:9
|
79 | fn evm_config(&self) -> impl ConfigureEvm + '_ {
| - let's call the lifetime of this reference `'1`
80 | self.inner.evm_config()
| ^^^^^^^^^^^^^^^^^^^^^^^ returning this value requires that `'1` must outlive `'static`
Co-authored-by: Matthias Seitz <[email protected]>
… emhane/ethapi-txns
emhane
requested review from
joshieDo,
rkrasiuk,
fgimenez,
rakita and
gakonst
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EthTransactionsimpl involving state to default trait methodsEthStatefor rpc methods related to stateLoadStateused inEthTransactions,EthState, debug, trace and call rpc methodsLeaves methods in
EthTransactionsimpl, that are yet to be moved to default trait method impls so that they are ported to any network by default: