refactor(node-builder): use datadir provided by the config #8592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
added
C-debt
shekhirin
force-pushed
the
alexey/node-config-datadir
branch
from
c005a3d to
c745eaa
Compare
shekhirin
force-pushed
the
alexey/node-config-datadir
branch
from
c745eaa to
087b9d3
Compare
This reverts commit 087b9d3.
shekhirin
requested review from
mattsse,
rakita,
joshieDo,
Rjected,
onbjerg and
gakonst
as code owners
shekhirin
force-pushed
the
alexey/node-config-datadir
branch
from
14fab24 to
554c024
Compare
onbjerg
approved these changes
Jun 4, 2024
mattsse
approved these changes
Jun 4, 2024
| @@ -183,7 +183,7 @@ impl<Ext: clap::Args + fmt::Debug> NodeCommand<Ext> { | |||
|
|
|||
| let builder = NodeBuilder::new(node_config) | |||
| .with_database(database) | |||
| .with_launch_context(ctx.task_executor, data_dir); | |||
| .with_launch_context(ctx.task_executor); | |||
| @@ -266,7 +266,7 @@ where | |||
| Err(EthApiError::InvalidTransaction(RpcInvalidTransactionError::GasTooHigh)) | |||
| if tx_request_gas_limit.is_some() || tx_request_gas_price.is_some() => | |||
| { | |||
| return Err(self.map_out_of_gas_err(block_env_gas_limit, env, &mut db)); | |||
| return Err(self.map_out_of_gas_err(block_env_gas_limit, env, &mut db)) | |||
mattsse
reviewed
Jun 4, 2024
| task_executor: TaskExecutor, | ||
| ) -> WithLaunchContext<NodeBuilder<Arc<TempDatabase<DatabaseEnv>>>> { | ||
| let path = MaybePlatformPath::<DataDirPath>::from(tempdir_path()); | ||
| self.config.datadir.datadir = path.clone(); |
There was a problem hiding this comment.
can we add setter for this on NodeConfig @shekhirin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have datadir arguments inside the node config with #7212, we can grab the datadir path directly from there.