Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement EIP-2935 #8431

Merged
merged 18 commits into from
May 30, 2024
Merged

feat: implement EIP-2935 #8431

merged 18 commits into from
May 30, 2024

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented May 28, 2024 •
edited
Loading

Extracted from #8214

Implements the EIP-2935 without BLOCKHASH opcode changes, i.e. only system contract storage is populated, but EVM behavior is left unchanged.

@shekhirin shekhirin added C-enhancement New feature or request A-execution Related to the Execution and EVM E-prague Related to the prague network upgrade labels May 28, 2024
rakita
rakita requested changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left few comments, PR needs to be updated to devnet-1 changes

@shekhirin shekhirin marked this pull request as ready for review May 29, 2024 16:25
@shekhirin shekhirin requested a review from rakita May 30, 2024 11:18
rakita
rakita approved these changes May 30, 2024
View reviewed changes
Copy link
Collaborator

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mattsse
mattsse approved these changes May 30, 2024
View reviewed changes
@shekhirin shekhirin added this pull request to the merge queue May 30, 2024
Merged via the queue into main with commit 633b655 May 30, 2024
48 of 51 checks passed
@shekhirin shekhirin deleted the alexey/eip-2935 branch May 30, 2024 12:29
mw2000 pushed a commit to mw2000/reth that referenced this pull request Jun 5, 2024
@shekhirin @onbjerg
@gakonst @mw2000
feat: implement EIP-2935 (paradigmxyz#8431)
cb3116c 
Co-authored-by: Oliver Nordbjerg <[email protected]>
Co-authored-by: Georgios Konstantopoulos <[email protected]>
@shekhirin shekhirin mentioned this pull request Jun 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakita rakita rakita approved these changes

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@gakonst gakonst Awaiting requested review from gakonst

Assignees
No one assigned
Labels
A-execution Related to the Execution and EVM C-enhancement New feature or request E-prague Related to the prague network upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shekhirin @rakita @mattsse @onbjerg