-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(op): filter out receipts for dup txns #8400
Conversation
@@ -43,6 +43,7 @@ members = [ | |||
"crates/optimism/evm/", | |||
"crates/optimism/node/", | |||
"crates/optimism/payload/", | |||
"crates/optimism/primitives/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let me know if I should remove this and put the type contained in the crate back in reth-primitives
, wanted to make a move in this direction @mattsse
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not obvious what is fix and what is refactor here.
the import receipt cmd is only useful for op mainnet, I don't think maintaining two versions of this command is useful
op is the only use case we have thought of at least, happy if reth is used in other ways for example by researchers. in testing, the fact that |
scope of the pr grew a bit to update the book @mattsse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pedantic style nit
After importing receipts and blocks + init state

After syncing 1M blocks
