Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(op): filter out receipts for dup txns #8400

Merged
merged 23 commits into from
May 28, 2024
Merged

Conversation

emhane
Copy link
Member

@emhane emhane commented May 25, 2024

  • Filters out receipts for duplicate transactions, which have been filtered out for txns already
  • Moves import bedrock receipts to new command
  • Fixes tracing
  • Coherency checks, consistency with transaction static files

After importing receipts and blocks + init state
Screenshot 2024-05-25 at 16 18 48

After syncing 1M blocks
Screenshot 2024-05-25 at 19 18 20

@@ -43,6 +43,7 @@ members = [
"crates/optimism/evm/",
"crates/optimism/node/",
"crates/optimism/payload/",
"crates/optimism/primitives/",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me know if I should remove this and put the type contained in the crate back in reth-primitives, wanted to make a move in this direction @mattsse

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not obvious what is fix and what is refactor here.

the import receipt cmd is only useful for op mainnet, I don't think maintaining two versions of this command is useful

@emhane
Copy link
Member Author

emhane commented May 27, 2024

not obvious what is fix and what is refactor here.

the import receipt cmd is only useful for op mainnet, I don't think maintaining two versions of this command is useful

op is the only use case we have thought of at least, happy if reth is used in other ways for example by researchers. in testing, the fact that import, import-receipts and init-state are generic commands, allows starting the chain at any given height

@emhane emhane requested a review from mattsse May 27, 2024 10:16
@emhane
Copy link
Member Author

emhane commented May 27, 2024

scope of the pr grew a bit to update the book @mattsse

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pedantic style nit

@emhane emhane added this pull request to the merge queue May 28, 2024
Merged via the queue into main with commit 3e7f137 May 28, 2024
31 checks passed
@emhane emhane deleted the emhane/op-filter-receipts branch May 28, 2024 17:05
mw2000 pushed a commit to mw2000/reth that referenced this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants