Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: sidecar fetcher #7443

Merged
merged 38 commits into from
May 28, 2024
Merged

feat: sidecar fetcher #7443

merged 38 commits into from
May 28, 2024

Conversation

JackG-eth
Copy link
Contributor

Solves #7419

Currently in Draft mode, do not review atm.

@shekhirin shekhirin added A-tx-pool Related to the transaction mempool C-example Examples labels Apr 10, 2024
@JackG-eth
Copy link
Contributor Author

@mattsse i think v1 is done, take a look

  • Missing tests atm.

mattsse
mattsse requested changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great already,

left some suggestions

@onbjerg onbjerg changed the title Feature: sidecar fetcher feat: sidecar fetcher Apr 24, 2024
mattsse
mattsse requested changes Apr 27, 2024
View reviewed changes
This was referenced May 2, 2024
Merged
Merged
@JackG-eth JackG-eth mentioned this pull request May 7, 2024
Merged
@JackG-eth
Copy link
Contributor Author

Quick update for visibility:

This required a couple of changes to alloy which are now done, just waiting for my test node to sync to test this but should hopefully close it out as soon as its ready.

@JackG-eth JackG-eth marked this pull request as ready for review May 16, 2024 09:31
@JackG-eth JackG-eth requested a review from gakonst as a code owner May 16, 2024 09:31
@JackG-eth
Copy link
Contributor Author

Hey all!

Tested this with a Holesky node and it seemed to be working as expected.

If someone else could test it with a node that would be great as well.

@mattsse Ready for review.

mattsse
mattsse requested changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome,

conceptionally this is complete, now we just need to do some cleanup and add a few features

mattsse
mattsse requested changes May 27, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last pedantic naming nits

@JackG-eth
Copy link
Contributor Author

Nits should be fixed and logic for handling granularity has been added.

mattsse
mattsse approved these changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, ty.

I just moved most impls to the sidecar mod

@mattsse mattsse enabled auto-merge May 28, 2024 10:05
@mattsse mattsse added this pull request to the merge queue May 28, 2024
Merged via the queue into paradigmxyz:main with commit d5bdb8e May 28, 2024
31 checks passed
@JackG-eth JackG-eth mentioned this pull request May 30, 2024
Closed
mw2000 pushed a commit to mw2000/reth that referenced this pull request Jun 5, 2024
@JackG-eth @mattsse @mw2000
feat: sidecar fetcher (paradigmxyz#7443)
504fcf8 
Co-authored-by: Matthias Seitz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-tx-pool Related to the transaction mempool C-example Examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JackG-eth @mattsse @shekhirin