feat(net): Metered senders

[akirillo]

Resolves #140, intended to build on top of #707

[akirillo]

@onbjerg would appreciate a quick glance at my current approach here to address #140!
Should I also add a BandwidthMeter a la #707 so that we can gauge / count outbound bandwidth from the sender?

[codecov-commenter]

Codecov Report

Merging #726 (c2b31f5) into main (75fab00) will increase coverage by 0.28%.
The diff coverage is 36.36%.

@@            Coverage Diff             @@
##             main     #726      +/-   ##
==========================================
+ Coverage   73.55%   73.83%   +0.28%     
==========================================
  Files         280      284       +4     
  Lines       29898    30157     +259     
==========================================
+ Hits        21991    22267     +276     
+ Misses       7907     7890      -17     

Flag	Coverage Δ
unit-tests	73.83% <36.36%> (+0.28%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
crates/metrics/common/src/metered_sender.rs	0.00% <0.00%> (ø)
crates/metrics/common/src/lib.rs	100.00% <100.00%> (ø)
crates/net/common/src/bandwidth_meter.rs	94.70% <100.00%> (ø)
crates/net/network/src/listener.rs	77.27% <0.00%> (-6.82%)	⬇️
crates/transaction-pool/src/test_utils/mock.rs	53.11% <0.00%> (-6.60%)	⬇️
crates/primitives/src/chain.rs	90.81% <0.00%> (-2.60%)	⬇️
crates/primitives/src/transaction/mod.rs	88.57% <0.00%> (-1.27%)	⬇️
bin/reth/src/config.rs	62.00% <0.00%> (-1.27%)	⬇️
crates/transaction-pool/src/pool/txpool.rs	58.87% <0.00%> (-0.50%)	⬇️
crates/net/eth-wire/src/disconnect.rs	83.45% <0.00%> (-0.49%)	⬇️
... and 33 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[gakonst]

Wrapping around the type and tracking makes sense, do we intend to integrate this anywhere in this PR?

[mattsse]

this is not limited to network, we can use this for any bounded channel that we want to monitor.
so perhaps we move this to a separate crate?

[akirillo]

I moved it to common/metrics/metered_sender.rs, that work?

[akirillo]

Wrapping around the type and tracking makes sense, do we intend to integrate this anywhere in this PR?

Am happy to! Would appreciate any pointers on where this would be the highest signal, maybe in the Senders used in the discv4 crate?

[onbjerg]

Marked this as blocked on #785

[akirillo]

Note to self: add docs to metrics.md after #785 is merged

[gakonst]

Unblocked @akirillo we got #785 in now!

[akirillo]

making use of dynamic scope now - any suggestions on where to integrate this metric? which senders do we care the most about? @gakonst

[gakonst]

This probably should be under crates/metrics right?

@mattsse when u get a chance if you can point at some senders that would benefit from this

[mattsse]

lgtm

[gakonst]

looks good - we should identify where we have senders and wrap them around this in a followup