fix(metrics): fix missing metrics by installing prometheus before creating db env #6659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevazhidkov
commented
Feb 18, 2024
| @@ -121,7 +126,6 @@ impl<DB: Database + DatabaseMetrics + DatabaseMetadata + 'static> NodeBuilderWit | |||
| let config = self.load_config()?; | |||
|
|
|||
| let prometheus_handle = self.config.install_prometheus_recorder()?; | |||
| info!(target: "reth::cli", "Database opened"); | |||
There was a problem hiding this comment.
moved this, because it seemed misplaced
mattsse
approved these changes
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a suggested alternative fix to a problem introduced in #6573. The previous fix was #6621 (registering metrics on first write vs
new).Problem TLDR:
DatabaseEnvMetricspre-registers all metrics atnew, but if metrics recorder isn't available at this point, all future metric writes will NOOP.This solution here is to register a metric recorder (via dereferencing a lazy static) prior to opening a database environment. Second
self.config.install_prometheus_recorder()still remains in therethnode builder to be used instart_metrics_endpoint.