Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance tx gossip test coverage #6578

Merged
merged 5 commits into from
Feb 16, 2024
Merged

enhance tx gossip test coverage #6578

merged 5 commits into from
Feb 16, 2024

Conversation

i-m-aditya
Copy link
Contributor

@i-m-aditya i-m-aditya commented Feb 13, 2024 •
edited
Loading

Fixes #6501

  • Check that bad transactions are rejected
  • Test peer penalization when blob txs(EIP-4844 Blob tx) are gossiped
  • Add helper functions for TransactionGenerator.

emhane
emhane requested changes Feb 13, 2024
View reviewed changes
Copy link
Member

@emhane emhane left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, appreciate that you moved as much of the reusable test rigging code as possible out into methods

emhane
emhane requested changes Feb 13, 2024
View reviewed changes
Copy link
Member

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't quite get why there was a 15 second time out at first, it's unnecessarily long to pause 15 seconds in ci, but yes, we need to give the test rig some time to send the tx, you were right. a second should do.

emhane
emhane requested changes Feb 14, 2024
View reviewed changes
@emhane emhane enabled auto-merge February 14, 2024 17:04
auto-merge was automatically disabled February 15, 2024 14:04

Head branch was pushed to by a user without write access

@i-m-aditya i-m-aditya force-pushed the i-m-aditya/enhancec-tx-gossip-test-coverage branch from eb5a0b4 to dcc9da4 Compare February 15, 2024 14:42
@emhane emhane enabled auto-merge February 15, 2024 16:18
auto-merge was automatically disabled February 15, 2024 19:36

Head branch was pushed to by a user without write access

@emhane emhane enabled auto-merge February 16, 2024 04:32
@emhane emhane added this pull request to the merge queue Feb 16, 2024
Merged via the queue into paradigmxyz:main with commit e24eadf Feb 16, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emhane emhane emhane approved these changes

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance Transaction Gossip Test Coverage
2 participants
@i-m-aditya @emhane