Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(revm): calculate failed transaction hash for logging #6556

Merged
merged 9 commits into from
Feb 17, 2024
Merged

fix(revm): calculate failed transaction hash for logging #6556

merged 9 commits into from
Feb 17, 2024

Conversation

justcode740
Copy link
Contributor

Closes #6544.

@justcode740 justcode740 requested a review from mattsse as a code owner February 12, 2024 06:42
@justcode740 justcode740 force-pushed the 0x/fix-tx-hash-is-default-in-err-msg branch from 9954af1 to f704ee5 Compare February 12, 2024 23:36
mattsse
mattsse requested changes Feb 13, 2024
View reviewed changes
@justcode740 justcode740 requested a review from mattsse February 13, 2024 00:33
@shekhirin shekhirin added C-bug An unexpected or incorrect behavior A-staged-sync Related to staged sync (pipelines and stages) A-observability Related to tracing, metrics, logs and other observability tools labels Feb 13, 2024
@shekhirin shekhirin changed the title calc failed tx hash err log and add a test fix(revm): calculate failed transaction hash for logging Feb 13, 2024
Rjected
Rjected approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@justcode740 justcode740 requested a review from Rjected February 16, 2024 19:59
@emhane emhane enabled auto-merge February 16, 2024 23:17
@justcode740
Copy link
Contributor Author

justcode740 commented Feb 16, 2024 •
edited
Loading

looks good to me

oh, hey seem i accidentally trigger many reviewer that don't need to review this, should i revert the review request or close this and open a new one? @Rjected. oh, maybe coz the requested changes somehow marked as unaddressed, need an approval from @mattsse

@emhane emhane added this pull request to the merge queue Feb 17, 2024
mattsse
mattsse approved these changes Feb 17, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Merged via the queue into paradigmxyz:main with commit 81b5c53 Feb 17, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@emhane emhane emhane approved these changes

@joshieDo joshieDo Awaiting requested review from joshieDo

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg

@gakonst gakonst Awaiting requested review from gakonst

@shekhirin shekhirin Awaiting requested review from shekhirin

@Rjected Rjected Awaiting requested review from Rjected

Assignees
No one assigned
Labels
A-observability Related to tracing, metrics, logs and other observability tools A-staged-sync Related to staged sync (pipelines and stages) C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transaction hash is not displayed on EVM block validation errors in the pipeline
5 participants
@justcode740 @shekhirin @Rjected @mattsse @emhane