Cache invalid txns #6542
Merged
Cache invalid txns #6542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p-request-buffered-hashes
…param to fill_request_from_buffer_for_peer
emhane
changed the base branch from
main
to
emhane/speed-up-request-buffered-hashes
mattsse
approved these changes
Feb 11, 2024
mattsse
added
C-perf
Base automatically changed from
emhane/speed-up-request-buffered-hashes
to
main
February 13, 2024 19:08
|
can be closed @emhane ? |
nope will fix conflicts and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6350.
Removes transactions also from
TransactionFetcheron_bad_import. On checking for vacant entry in pool imports or tx fetcher hashes, checks if tx is actually new by checking if it's inbad_importscache already.