perf(trie): hashed state from revert range #6485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkrasiuk
added
C-perf
joshieDo
reviewed
Feb 8, 2024
| this.storages.insert(keccak256(address), hashed_storage); | ||
| } | ||
| let hashed_accounts = HashMap::from_iter( | ||
| accounts.into_iter().map(|(address, info)| (keccak256(address), info)), |
There was a problem hiding this comment.
could this benefit from rayon?
There was a problem hiding this comment.
i'm unsure about exact size yet, so stayed clear of rayon for now
joshieDo
reviewed
Feb 8, 2024
| // should be looked up in db or not. For reverts it's a noop since all | ||
| // wiped changes had been written as storage reverts. | ||
| false, | ||
| storage.into_iter().map(|(slot, value)| (keccak256(slot), value)), |
There was a problem hiding this comment.
could this benefit from rayon?
DaniPopes
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description