Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop lock on listener as early as possible #6414

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Drop lock on listener as early as possible #6414

merged 2 commits into from
Feb 6, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Feb 5, 2024

Releases a write lock in tx pool as early as possible.

@emhane emhane requested a review from mattsse as a code owner February 5, 2024 17:23
Rjected
Rjected approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, lgtm

mattsse
mattsse requested changes Feb 5, 2024
View reviewed changes
@onbjerg onbjerg requested a review from mattsse February 6, 2024 08:12
@mattsse mattsse added this pull request to the merge queue Feb 6, 2024
Merged via the queue into main with commit 4afc3b7 Feb 6, 2024
28 checks passed
@mattsse mattsse deleted the emhane/drop-lock-listener branch February 6, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

@onbjerg onbjerg onbjerg approved these changes

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emhane @Rjected @onbjerg @mattsse